Replace Android ToSpannableString overload#27597
Merged
jfversluis merged 1 commit intonet10.0from Feb 7, 2025
Merged
Conversation
jfversluis
requested review from
mattleibow and
rmarinho
and removed request for
a team
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt: Language not supported
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Platform/Android/Extensions/FormattedStringExtensions.cs:29
- Ensure that the new method ToSpannableStringNewWay is covered by tests in TestCases.Shared.Tests and can execute properly on TestCases.HostApp.
this FormattedString formattedString,
src/Controls/src/Core/Platform/Android/Extensions/FormattedStringExtensions.cs
Show resolved
Hide resolved
Contributor
|
🚨 API change(s) detected @davidbritch FYI |
jsuarezruiz
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves a TODO in code to replace the Android FormattedStringExtensions.ToSpannableString overload
Contributes to #8989